Relaxes Node naming constraints in glTF documents to match the Editor. #46939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better if the commit message was the same as in the original, so that the gist of it is clear without jumping through referenced issues and PRs. |
abaire
force-pushed
the
relaxes_gltf_name_sanitization_3.2
branch
from
0159bc8
to
b032067
Compare
Excellent point, fixed. |
|
I'm not able to test, but I approve if it's the same results on 3.2 as master. |
akien-mga
changed the title
akien-mga
approved these changes
Mar 13, 2021
|
Thanks! |
|
There was discussion that this is a breaking change that causes all the node-path referenced by [game developer] code to possibly change and break everything in a Godot Engine minor release. Will try to find the extent of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicated backport as requested by @akien-mga on #45545